Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS-3156 Review glossary. Adjust capitalization and bolding. #1158

Merged
merged 2 commits into from
Aug 16, 2023
Merged

ECS-3156 Review glossary. Adjust capitalization and bolding. #1158

merged 2 commits into from
Aug 16, 2023

Conversation

NeilBurgess42
Copy link
Contributor

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #YYY or Closes #YYY

@Alenar
Copy link
Collaborator

Alenar commented Aug 11, 2023

Nice work, thanks !
Can you take a look @olgahryniuk ? ( I'm taking over since JP is on break for the next two weeks 🏖️ )

@olgahryniuk
Copy link
Collaborator

Thank you @NeilBurgess42 and @Alenar! Committed some more tweaks - LGTM for further approval/merging :)

Alenar
Alenar approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Alenar Alenar merged commit c07f297 into input-output-hk:main Aug 16, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@olgahryniuk olgahryniuk olgahryniuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeilBurgess42 @Alenar @olgahryniuk